Add subscription properties for SubscriptionStats #12979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
Jason918
approved these changes
Nov 27, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
Signed-off-by: xiaolongran <xiaolongran@tencent.com> ### Motivation In apache#12869 , we introduce new filed `subscriptionProperties` in `CommandSubsctibe`. In order to better query the subscriptionProperties set by the user, we will display this property in SubscribeStats ### Modifications - Add subscription properties for SubscriptionStats - add test case
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
Signed-off-by: xiaolongran <xiaolongran@tencent.com> ### Motivation In apache#12869 , we introduce new filed `subscriptionProperties` in `CommandSubsctibe`. In order to better query the subscriptionProperties set by the user, we will display this property in SubscribeStats ### Modifications - Add subscription properties for SubscriptionStats - add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolongran xiaolongran@tencent.com
Motivation
In #12869 , we introduce new filed
subscriptionPropertiesinCommandSubsctibe. In order to better query the subscriptionProperties set by the user, we will display this property in SubscribeStatsModifications