Skip to content

[Tests] Remove unused mockZooKeeperClientFactory fields #13093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lhotari wants to merge 1 commit into from
Closed

[Tests] Remove unused mockZooKeeperClientFactory fields #13093

lhotari wants to merge 1 commit into from

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Dec 2, 2021

Motivation

There are unused mockZooKeeperClientFactory fields in a few test classes.

Modifications

Remove the unused mockZooKeeperClientFactory fields.

@lhotari lhotari added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use doc-not-needed Your PR changes do not impact docs labels Dec 2, 2021
@lhotari lhotari requested review from eolivelli and merlimat December 2, 2021 14:09
@lhotari lhotari self-assigned this Dec 2, 2021
@lhotari lhotari added this to the 2.10.0 milestone Dec 2, 2021
@merlimat
Copy link
Contributor

merlimat commented Dec 2, 2021

@lhotari I already have a change that does this and also removes the interface and implementations completely. It's pending on merging #13077.

@lhotari lhotari closed this Dec 2, 2021
@lhotari
Copy link
Member Author

lhotari commented Dec 2, 2021

Closed since #13077 handles this.

@lhotari lhotari deleted the lh-remove-unused-mockZooKeeperClientFactory-fields branch December 2, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merlimat merlimat Awaiting requested review from merlimat

@eolivelli eolivelli Awaiting requested review from eolivelli

Assignees

@lhotari lhotari

Labels

doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

@lhotari @merlimat