[pulsar-broker] load-balancer support disabling max-session for bundle split #13108
Conversation
rdhabalia
requested review from
codelipenghui,
eolivelli,
jiazhai,
merlimat and
sijie
|
@rdhabalia:Thanks for your contribution. For this PR, do we need to update docs? |
| @FieldContext( | ||
| category = CATEGORY_LOAD_BALANCER, | ||
| doc = "maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered" | ||
| + "(disable threshold check with value -1)" |
There was a problem hiding this comment.
nit:
| + "(disable threshold check with value -1)" | |
| + " (disable threshold check with value -1)" |
| loadBalancerNamespaceBundleMaxTopics=1000 | ||
|
|
||
| # maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered | ||
| # (disable threshold check with value -1) |
There was a problem hiding this comment.
@rdhabalia for the doc side, there are 2 loadBalancerNamespaceBundleMaxSessions in the Pulsar configuration page, need to add the explanations for both?
There was a problem hiding this comment.
@rdhabalia - will you be able to update this documentation? If not, I still think we should merge this PR and maybe someone can follow up with a PR to update the docs?
There was a problem hiding this comment.
yes, these config are not related to this change and already exist, but will create a separate PR to address documentation concerns.
Anonymitaet
added
doc-required
Anonymitaet
added
doc-complete
6 participants
Motivation
Right now, Bundle split task considers max-session count on topic to split bundle and in some usecases, we want to disable this threshold-check because some usecases have expected number of high producer/consumer connection and we don't want to split based on this criteria. so, provide a way to disable this check by setting -1 value which skips the threshold check.