Close old compacted ledger when open new. #13210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Dec 10, 2021
codelipenghui
requested review from
315157973,
MarvinCai,
congbobo184,
gaoran10,
hangc0276 and
merlimat
eolivelli
pushed a commit
that referenced
this pull request
Dec 13, 2021
(cherry picked from commit 07ef923)
eolivelli
added
cherry-picked/branch-2.9
eolivelli
pushed a commit
that referenced
this pull request
Dec 13, 2021
(cherry picked from commit 07ef923)
eolivelli
added
cherry-picked/branch-2.9
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
zymap
pushed a commit
that referenced
this pull request
Dec 23, 2021
(cherry picked from commit 07ef923)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is related #12522 .
#12522 has make CompactedTopicImpl#newCompactedLedger to return the old compacted ledger, so it needs to close the old ledgers when open new.
If we don't close the old ledgers, the old ledger may keep open, and cause the resources leak.
Documentation
no-need-doc