[Doc] add explanations for broker entry metadata #13336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anonymitaet
added
the
doc
Anonymitaet
requested review from
BewareMyPower,
Huanli-Meng and
codelipenghui
Member
Author
|
@BewareMyPower @codelipenghui @Huanli-Meng can you help review? Thanks |
hezhangjian
requested changes
Dec 16, 2021
Huanli-Meng
approved these changes
Dec 16, 2021
Contributor
Huanli-Meng
left a comment
Huanli-Meng
left a comment
There was a problem hiding this comment.
LGTM and only leave one minor comment.
hezhangjian
approved these changes
Dec 16, 2021
BewareMyPower
approved these changes
Dec 16, 2021
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Dec 29, 2021
* [Doc] add explanations for broker entry metadata * update * update
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Jun 15, 2022
* [Doc] add explanations for broker entry metadata * update * update (cherry picked from commit 1f80634)
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 16, 2022
* [Doc] add explanations for broker entry metadata * update * update (cherry picked from commit 1f80634)
Contributor
BewareMyPower
left a comment
BewareMyPower
left a comment
There was a problem hiding this comment.
I just noticed the typo. The config should be exposingBrokerEntryMetadataToClientEnabled , not enableExposingBrokerEntryMetadataToClient. Could you fix it?
See
Contributor
|
@Anonymitaet could you please help follow up with @BewareMyPower 's comments? Thanks. |
1 task
Member
Author
|
@BewareMyPower sorry I missed your comment @Huanli-Meng thanks for your reminder! I've updated it in #17099, PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docs for #11553 and https://apache-pulsar.slack.com/archives/C5Z4T36F7/p1639493174300500
Preview looks good:
