[Client]Allow to override PULSAR_MEM settings via PULSAR_EXTRA_OPS #13381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pulsar-client` runs `conf/pulsar_tools_env.sh` to set `PULSAR_EXTRA_OPTS`. If `PULSAR_EXTRA_OPTS` are given in the command line and contain `-Xmx`, it will be overridden by `PULSAR_MEM`.
lhotari
reviewed
Dec 17, 2021
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Dec 17, 2021
lhotari
requested review from
315157973,
aahmed-se,
eolivelli,
merlimat and
michaeljmarshall
Member
|
Why we need this feature, you can config both |
Member
@shoothzj I believe that this change improves consistency. The assumption is that you can override other options by setting them in PULSAR_EXTRA_OPTS. I made a similar improvement to consistency for |
codelipenghui
approved these changes
Dec 23, 2021
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Dec 29, 2021
…pache#13381) ### Motivation `pulsar-client` runs `conf/pulsar_tools_env.sh` to set `PULSAR_EXTRA_OPTS`. If `PULSAR_EXTRA_OPTS` are given in the command line and contain `-Xmx`, it will be overridden by `PULSAR_MEM`. ### Modifications Exchange the order of applying env variables. First go the hardcoded PULSAR_MEM settings, then potentially the user settings.
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2022
…ache#13381 (cherry picked from commit 0c2eaa2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
pulsar-clientrunsconf/pulsar_tools_env.shto setPULSAR_EXTRA_OPTS. IfPULSAR_EXTRA_OPTSare given in the command line and contain-Xmx, it will be overridden byPULSAR_MEM.Modifications
Exchange the order of applying env variables. First go the hardcoded PULSAR_MEM settings, then potentially the user settings.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docChange in a shell script, which is not documented.