Add publishRateLimitedTimes to topic metrics #13538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
315157973
requested review from
codelipenghui,
eolivelli,
gaoran10,
hangc0276 and
michaeljmarshall
codelipenghui
approved these changes
Jan 21, 2022
codelipenghui
added
doc-required
Contributor
|
@315157973 Since the PR introduced a new metric, I added the doc-required label. |
Jason918
reviewed
Jan 21, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
Outdated
Show resolved
Hide resolved
# Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java
Jason918
reviewed
Jan 22, 2022
Contributor
Jason918
left a comment
Jason918
left a comment
There was a problem hiding this comment.
Can we add rate limit count in org.apache.pulsar.broker.service.ServerCnx#disableCnxAutoRead.
This is the place rate limit actual take effects.
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
Outdated
Show resolved
Hide resolved
Member
|
Discussed w/ @315157973, from the doc side, he will add the newly added metrics to https://pulsar.apache.org/docs/en/next/reference-metrics/#topic-metrics. |
…other Topic use the same connections are inaccurate.
codelipenghui
approved these changes
Jan 26, 2022
Jason918
reviewed
Jan 26, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
Outdated
Show resolved
Hide resolved
Anonymitaet
added
doc-complete
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
### Motivation Broker limits the rate of publishing messages by setting `channel.setAutoRead(false)`. But no exception is returned to the client, or any log is printed, which makes it very difficult for user to troubleshoot the problem. When the Producer is limited, the client will send timeout and the connection will be closed (Broker no longer process the Client's heartbeat request, because autoRead=false). We don't know if there is a problem with network or the rate is limited or other reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Broker limits the rate of publishing messages by setting
channel.setAutoRead(false). But no exception is returned to the client, or any log is printed, which makes it very difficult for user to troubleshoot the problem. When the Producer is limited, the client will send timeout and the connection will be closed (Broker no longer process the Client's heartbeat request, because autoRead=false). We don't know if there is a problem with network or the rate is limited or other reasons.Modifications
Add publishRateLimitedTimes to topic metrics
Documentation
no-need-doc