Skip to content

Avoid call sync method in async rest API for force delete subscription #13668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 6 commits into from
Jan 12, 2022
Merged

Avoid call sync method in async rest API for force delete subscription #13668

codelipenghui merged 6 commits into from
Jan 12, 2022

Conversation

@mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Jan 7, 2022

Motivation

Same to #13666

Modifications

  • Change sync method to async.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: ( no )
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 7, 2022
@mattisonchao
Copy link
Member Author

mattisonchao commented Jan 7, 2022

@codelipenghui

PTAL :)

@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 7, 2022
eolivelli
eolivelli approved these changes Jan 8, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@eolivelli
Copy link
Contributor

eolivelli commented Jan 8, 2022

@codelipenghui please don't add labels to cherry pick this kind of patches to branch 2.8 and 2.9.

We should cherry pick only critical fixes

@eolivelli
Copy link
Contributor

eolivelli commented Jan 10, 2022

@codelipenghui can you please take another look ?

@codelipenghui
Copy link
Contributor

codelipenghui commented Jan 12, 2022

@mattisonchao I have left a few comments, PTAL.

mattisonchao and others added 2 commits January 12, 2022 17:42
@mattisonchao @codelipenghui
Update pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/imp…
44f8883 
…l/PersistentTopicsBase.java

Co-authored-by: lipenghui <penghui@apache.org>
@mattisonchao @codelipenghui
Update pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/imp…
f39a6d0 
…l/PersistentTopicsBase.java

Co-authored-by: lipenghui <penghui@apache.org>
@mattisonchao
Copy link
Member Author

mattisonchao commented Jan 12, 2022

@mattisonchao I have left a few comments, PTAL.

I will fix it ASAP.

@codelipenghui
Copy link
Contributor

codelipenghui commented Jan 12, 2022

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 416e7e5 into apache:master Jan 12, 2022
@merlimat merlimat added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Jan 13, 2022
merlimat pushed a commit that referenced this pull request Jan 13, 2022
@mattisonchao @merlimat
Avoid call sync method in async rest API for force delete subscription (
2a0be4b 
#13668)
codelipenghui pushed a commit that referenced this pull request Jan 18, 2022
@mattisonchao @codelipenghui
Avoid call sync method in async rest API for force delete subscription (
4f80414 
#13668)

(cherry picked from commit 416e7e5)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jason918 Jason918 Jason918 approved these changes

@eolivelli eolivelli eolivelli approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@mattisonchao mattisonchao

Labels

area/broker cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.3 release/2.9.2

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

6 participants

@mattisonchao @eolivelli @codelipenghui @Jason918 @merlimat @gaoran10