[Transaction] Set TC state is Ready after open MLTransactionMetadataStore completely. #13957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tore completely. ### Motivation The MLTransactionMetadataStore constructor and openTransactionMetadataStore method are asynchronous. So there may be situations where the store in the Initializing state was put into stores ### Modification Pass in a future to wait for MLTransactionMetadataStore initialization to complete
congbobo184
reviewed
Jan 26, 2022
.../java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStoreProvider.java
Show resolved
Hide resolved
Contributor
Author
|
/pulsarbot run-failure-checks |
congbobo184
reviewed
Jan 27, 2022
...src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/pulsarbot run-failure-checks |
congbobo184
requested review from
codelipenghui,
eolivelli,
gaoran10 and
merlimat
congbobo184
approved these changes
Jan 29, 2022
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
eolivelli
reviewed
Jan 30, 2022
...src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
|
/pulsarbot run-failure-checks |
|
The pr had no activity for 30 days, mark with Stale label. |
|
The pr had no activity for 30 days, mark with Stale label. |
Member
|
Hi, @liangyepianzhou Could you please rebase this PR and fix the conflicts. |
mattisonchao
approved these changes
Jun 13, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Jun 28, 2022
…tore completely. (#13957) [Transaction] Set TC state is Ready after open MLTransactionMetadataStore completely. ### Motivation The MLTransactionMetadataStore constructor and openTransactionMetadataStore method are asynchronous. So there may be situations where the store in the Initializing state was put into stores ### Modification Pass in the future to wait for MLTransactionMetadataStore initialization to complete (cherry picked from commit 0fe8ac0)
mattisonchao
pushed a commit
that referenced
this pull request
Jul 2, 2022
…tore completely. (#13957) [Transaction] Set TC state is Ready after open MLTransactionMetadataStore completely. ### Motivation The MLTransactionMetadataStore constructor and openTransactionMetadataStore method are asynchronous. So there may be situations where the store in the Initializing state was put into stores ### Modification Pass in the future to wait for MLTransactionMetadataStore initialization to complete (cherry picked from commit 0fe8ac0)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 4, 2022
…tore completely. (apache#13957) [Transaction] Set TC state is Ready after open MLTransactionMetadataStore completely. ### Motivation The MLTransactionMetadataStore constructor and openTransactionMetadataStore method are asynchronous. So there may be situations where the store in the Initializing state was put into stores ### Modification Pass in the future to wait for MLTransactionMetadataStore initialization to complete (cherry picked from commit 0fe8ac0) (cherry picked from commit 3c0063b)
Closed
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
MLTransactionMetadataStoreconstructor andopenTransactionMetadataStoremethod are asynchronous.So there may be situations where the store in the Initializing state is put into stores
Modification
Pass in a future to wait for MLTransactionMetadataStore initialization to complete and then put it into stores.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)
doc-not-needed