Skip to content

Conversation

@nodece
Copy link
Member

@nodece nodece commented Jan 27, 2022

Motivation

Some documentation and config files miss the schema configuration.

Modifications

  • Add systemTopicSchemaCompatibilityStrategy, schemaCompatibilityStrategy, isSchemaValidationEnforced and schemaRegistryStorageClassName to conf/standalone.conf
  • Add miss schema configuration to reference-configuration.md

Documentation

@nodece
Copy link
Member Author

nodece commented Jan 27, 2022

@momo-jun Could you take a look?

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jan 27, 2022
@nodece
Copy link
Member Author

nodece commented Jan 27, 2022

/pulsarbot rerun-failure-checks

@nodece nodece force-pushed the add_schema_conf branch 3 times, most recently from 9be79f5 to ab01106 Compare January 28, 2022 03:42
@momo-jun
Copy link
Contributor

@Anonymitaet Can you pls review this doc PR?

Copy link
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL at my comments, thanks.

@nodece
Copy link
Member Author

nodece commented Feb 7, 2022

@Anonymitaet Sorry, I didn't notice the conflict.

|isSchemaValidationEnforced|Enforce schema validation on following cases: if a producer without a schema attempts to produce to a topic with schema, the producer will be failed to connect. PLEASE be carefully on using this, since non-java clients don't support schema. If this setting is enabled, then non-java clients fail to produce.|false|
|isSchemaValidationEnforced| Whether to enable schema validation, when schema validation is enabled, if a producer without a schema attempts to produce the message to a topic with schema, the producer is rejected and disconnected.|false|
|isAllowAutoUpdateSchemaEnabled|Allow schema to be auto updated at broker level.|true|
|schemaCompatibilityStrategy| The schema compatibility strategy at broker level, see [here](schema-evolution-compatibility.md#schema-compatibility-check-strategy) for available values.|FULL|
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use URL to avoid duplicate descriptions of available values.

@Anonymitaet
Copy link
Member

Anonymitaet commented Feb 7, 2022

Confirmed w/ @nodece, this PR adds doc for #13938

@nodece can you add something like this PR adds doc for <code-PR-link> so that others know your changes clearly? Thanks

@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Feb 7, 2022
@Anonymitaet Anonymitaet merged commit a23f33f into apache:master Feb 7, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants