Skip to content

[Broker] Set default value of applied to false in getSchemaCompatibilityStrategy #14012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 1 commit into from
Jan 29, 2022
Merged

[Broker] Set default value of applied to false in getSchemaCompatibilityStrategy #14012

codelipenghui merged 1 commit into from
Jan 29, 2022

Conversation

@yuruguo
Copy link
Contributor

@yuruguo yuruguo commented Jan 28, 2022

Motivation

In #13297, we should set default value of applied to false in getSchemaCompatibilityStrategy

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 28, 2022
@codelipenghui codelipenghui modified the milestones: 2.11.0, 2.10.0 Jan 28, 2022
Jason918
Jason918 approved these changes Jan 29, 2022
View reviewed changes
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just curious, is this applied implicitly default as false before this change?

@yuruguo
Copy link
Contributor Author

yuruguo commented Jan 29, 2022

LGTM. Just curious, is this applied implicitly default as false before this change?

Amdin Cli defaults applied to false, but the Rest API may not specify a value, so we need to give a default value on the broker side.

@Jason918
Copy link
Contributor

Jason918 commented Jan 29, 2022

the Rest API may not specify a value

It's boolean type, so it should be default as false if we does not pass it in REST api, right?

@codelipenghui codelipenghui merged commit f49ed2d into apache:master Jan 29, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@yuruguo
[Broker] Set default value of applied to false in getSchemaCompatibil…
a47ed43 
…ityStrategy (apache#14012)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jason918 Jason918 Jason918 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@mattisonchao mattisonchao mattisonchao approved these changes

Assignees

@yuruguo yuruguo

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@yuruguo @Jason918 @codelipenghui @mattisonchao