[Issue 14046] Fixes AsyncResponsedoes not resume when redirected.

[mattisonchao]

Fixes #14046

Motivation

Fixes AsyncResponsedoes not resume when redirected.

Modifications

• Add AsyncResponse#resume when redirected.

Verifying this change

• Make sure that the change passes the CI checks.

Documentation

Check the box below or label this PR directly (if you have committer privilege).

• no-need-doc

[mattisonchao]

/pulsarbot rerun-failure-checks

[mattisonchao]

/pulsarbot rerun-failure-checks

[mattisonchao]

@merlimat @lhotari @Jason918 PTAL :-)

[lhotari]

Change looks good, but would you be able to describe what kind of issues this caused? What was the end user impact? Any sample error logs? That could help find out if a particular problems is fixed by this change.

[mattisonchao]

Change looks good, but would you be able to describe what kind of issues this caused? What was the end user impact? Any sample error logs? That could help find out if a particular problems is fixed by this change.

@lhotari You can see #14046. this issue is because we lost an async response. that will hang the request until timeout when the request needs to redirect to another broker.

[lhotari]

@lhotari You can see #14046. this issue is because we lost an async response. that will hang the request until timeout when the request needs to redirect to another broker.

I'm sorry I missed that detail. I wonder if there are other problems that this PR fixes?
The fix is to production code.

[lhotari]

Would it be possible to add more test coverage that the missing redirect would be caught by a unit test or similar?

[mattisonchao]

Would it be possible to add more test coverage that the missing redirect would be caught by a unit test or similar?

Sure, i will do it ASAP.

[michaeljmarshall]

@lhotari - this bug appears to be introduced in #13805, which has not yet made it into a release.

[mattisonchao]

I think if we add a test for the admin side to test topic not own this broker will redirect to another broker action. maybe we need to add this test for all admin APIs that need to validate topic ownership, So, I think it needs a lot of work. ant I think we need to do it in another PR.