Skip to content

Conversation

@zzzming
Copy link
Contributor

@zzzming zzzming commented Feb 1, 2022

Fixes

The bug is Kubernetes function runtime's prometheus metrics port always binds to a random available port instead of using the metricsPort specified in FunctionRuntimeFactoryConfig from the functions_worker.yaml or default to 9094 from the KubernetesRuntimeFactoryConfig class.

This is a fix to address a bug introduced by this PR (#9610)

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • no-need-doc

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

@zzzming:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

@zzzming:Thanks for providing doc info!

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Feb 1, 2022
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add some unit tests ?

@lhotari
Copy link
Member

lhotari commented Mar 1, 2022

I created #14502 with tests and handling for disabling Prometheus Metrics for Pulsar Functions.

@lhotari lhotari closed this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants