Skip to content

[Broker] Move schema compatibility strategy cmd from topics to topicPolicies #14225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 1 commit into from
Feb 16, 2022
Merged

[Broker] Move schema compatibility strategy cmd from topics to topicPolicies #14225

codelipenghui merged 1 commit into from
Feb 16, 2022

Conversation

@nodece
Copy link
Member

@nodece nodece commented Feb 10, 2022 •
edited
Loading

Motivation

The schema-compatibility-strategy cmd should be in the topicPolicies subcommand, it is topic policies.

Modifications

  • Move the schema compatibility strategy cmd from topics to topicPolicies
  • Fix the schema compatibility strategy test

Documentation

Need to update docs?

@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Feb 10, 2022
michaeljmarshall
michaeljmarshall requested changes Feb 10, 2022
View reviewed changes
Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me that these are policy commands, but I don't think we can remove the existing commands just yet.

@Anonymitaet
Copy link
Member

Anonymitaet commented Feb 11, 2022

Hi @momo-jun can you follow up on the doc change? Thanks

@momo-jun
Copy link
Contributor

momo-jun commented Feb 11, 2022

Hi @momo-jun can you follow up on the doc change? Thanks

Sure, I will take care of it.

@nodece nodece force-pushed the move_schema_compatibility_strategy_cmd branch from a3d7237 to 61fa7d2 Compare February 11, 2022 04:59
@nodece
Copy link
Member Author

nodece commented Feb 11, 2022

/pulsarbot rerun-failure-checks

@momo-jun momo-jun mentioned this pull request Feb 11, 2022
Merged
1 task
@Anonymitaet
Copy link
Member

Anonymitaet commented Feb 11, 2022

Hi @nodece since this PR contains doc changes on https://pulsar.apache.org/tools/pulsar-admin/2.10.0-SNAPSHOT/#topicpolicies, please label this kind of PR w/ doc in the future, thanks.

@Anonymitaet Anonymitaet added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Feb 11, 2022
@nodece nodece force-pushed the move_schema_compatibility_strategy_cmd branch from 61fa7d2 to 3a0abba Compare February 11, 2022 07:59
@nodece
Copy link
Member Author

nodece commented Feb 11, 2022

@Anonymitaet Thanks.

@nodece nodece changed the title [Broker] Move schema compatibility strategy cmd from topics to topicsPolicies [Broker] Move schema compatibility strategy cmd from topics to topicPolicies Feb 11, 2022
@nodece nodece force-pushed the move_schema_compatibility_strategy_cmd branch from 3a0abba to a1aeed5 Compare February 11, 2022 10:33
@codelipenghui codelipenghui added this to the 2.10.0 milestone Feb 14, 2022
@nodece
Copy link
Member Author

nodece commented Feb 14, 2022

/pulsarbot rerun-failure-checks

3 similar comments
@nodece
Copy link
Member Author

nodece commented Feb 14, 2022

/pulsarbot rerun-failure-checks

@nodece
Copy link
Member Author

nodece commented Feb 14, 2022

/pulsarbot rerun-failure-checks

@nodece
Copy link
Member Author

nodece commented Feb 14, 2022

/pulsarbot rerun-failure-checks

@codelipenghui codelipenghui added the release/blocker Indicate the PR or issue that should block the release until it gets resolved label Feb 14, 2022
codelipenghui
codelipenghui previously approved these changes Feb 14, 2022
View reviewed changes
@nodece nodece requested a review from Jason918 February 14, 2022 13:13
Jason918
Jason918 previously approved these changes Feb 14, 2022
View reviewed changes
315157973
315157973 previously approved these changes Feb 14, 2022
View reviewed changes
RobertIndie
RobertIndie previously approved these changes Feb 14, 2022
View reviewed changes
@codelipenghui
Copy link
Contributor

codelipenghui commented Feb 14, 2022

@michaeljmarshall Please help review this PR again.

michaeljmarshall
michaeljmarshall requested changes Feb 14, 2022
View reviewed changes
Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the annotations may be incorrect. Can you take a look @nodece? Thanks.

@nodece
[Broker] Move schema compatibility strategy cmd from topics to topicP…
a4ba12d 
…olicies

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece force-pushed the move_schema_compatibility_strategy_cmd branch from 4078ec1 to a4ba12d Compare February 15, 2022 15:28
michaeljmarshall
michaeljmarshall approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the hope that we'll be able to improve the PulsarCliTestSuite in the near future. That improvement should be cherry-picked back to branch-2.10, too.

@nodece
Copy link
Member Author

nodece commented Feb 16, 2022

/pulsarbot rerun-failure-checks

@codelipenghui codelipenghui merged commit 244060a into apache:master Feb 16, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@nodece
[Broker] Move schema compatibility strategy cmd from topics to topicP…
7d1a332 
…olicies (apache#14225)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@RobertIndie RobertIndie RobertIndie left review comments

@eolivelli eolivelli Awaiting requested review from eolivelli

@315157973 315157973 Awaiting requested review from 315157973

@Jason918 Jason918 Awaiting requested review from Jason918

@michaeljmarshall michaeljmarshall Awaiting requested review from michaeljmarshall

Assignees

@nodece nodece

Labels

area/cli doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. doc-complete Your PR changes impact docs and the related docs have been already added. release/blocker Indicate the PR or issue that should block the release until it gets resolved

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

8 participants

@nodece @Anonymitaet @momo-jun @codelipenghui @Jason918 @315157973 @RobertIndie @michaeljmarshall