Skip to content

[Doc] Add a parameter to forcefully close fenced topics #14289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Anonymitaet merged 4 commits into from
Feb 17, 2022
Merged

[Doc] Add a parameter to forcefully close fenced topics #14289

Anonymitaet merged 4 commits into from
Feb 17, 2022

Conversation

@momo-jun
Copy link
Contributor

@momo-jun momo-jun commented Feb 15, 2022 •
edited
Loading

Modifications

  1. To align with [broker] Close topics that remain fenced forcefully #8561, add a parameter for both broker and standalone pulsar to forcefully close fenced topics.
  2. Remove a duplicate parameter from the list of standalone pulsar.

Note: This doc change will be applied to more historical versions (since 2.7.0) after the doc PR gets approval.

Preview

image

Documentation

  • doc

@github-actions
Copy link

github-actions bot commented Feb 15, 2022

@momo-jun:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions
Copy link

github-actions bot commented Feb 15, 2022

@momo-jun:Thanks for providing doc info!

@github-actions github-actions bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels Feb 15, 2022
@momo-jun
Copy link
Contributor Author

momo-jun commented Feb 15, 2022

Hi @massakam @codelipenghui @Anonymitaet, can you please review this PR? Thanks.

Please kindly note that this doc change will be applied to more historical versions (since 2.7.0) after the PR gets approval.

@momo-jun momo-jun changed the title [Doc] Add a parameter to forcefully close fenced topics [Doc] [Do-not-Merge] Add a parameter to forcefully close fenced topics Feb 15, 2022
massakam
massakam previously approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@massakam massakam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Anonymitaet
Anonymitaet reviewed Feb 16, 2022
View reviewed changes
@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Feb 16, 2022
momo-jun and others added 2 commits February 16, 2022 14:39
@momo-jun @Anonymitaet
Update site2/docs/reference-configuration.md
cd5484f 
Agreed.

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
@momo-jun
Present tense correction
e476d14
codelipenghui
codelipenghui previously approved these changes Feb 16, 2022
View reviewed changes
@codelipenghui codelipenghui modified the milestones: 2.10.0, 2.11.0 Feb 16, 2022
Anonymitaet
Anonymitaet previously approved these changes Feb 16, 2022
View reviewed changes
@momo-jun momo-jun dismissed stale reviews from Anonymitaet and codelipenghui via b6718e8 February 17, 2022 05:53
@momo-jun
Copy link
Contributor Author

momo-jun commented Feb 17, 2022

Thanks for your review and approval. I've applied the same changes to more historical versions since 2.7.0. PTAL.

Hi @massakam @codelipenghui @Anonymitaet, can you please review this PR? Thanks.

Please kindly note that this doc change will be applied to more historical versions (since 2.7.0) after the PR gets approval.

@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Feb 17, 2022
@Anonymitaet Anonymitaet merged commit d3848e2 into apache:master Feb 17, 2022
@Anonymitaet
Copy link
Member

Anonymitaet commented Feb 17, 2022

Ping @urfreespace we've merged this code PR, please do not forget to migrate changes, thanks

@momo-jun momo-jun changed the title [Doc] [Do-not-Merge] Add a parameter to forcefully close fenced topics [Doc] Add a parameter to forcefully close fenced topics Feb 19, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@momo-jun
[Doc] Add a parameter to forcefully close fenced topics (apache#14289)
23de277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anonymitaet Anonymitaet Anonymitaet approved these changes

@codelipenghui codelipenghui codelipenghui left review comments

@massakam massakam massakam left review comments

Assignees

@momo-jun momo-jun

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@momo-jun @Anonymitaet @codelipenghui @massakam