[Broker] Fix NPE in internalSkipMessages #14297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
force-pushed
the
fix_NPM_skip_message
branch
from
dc88b01 to
8da19ce
Compare
nodece
changed the title
nodece
force-pushed
the
fix_NPM_skip_message
branch
from
8da19ce to
702714a
Compare
eolivelli
approved these changes
Feb 15, 2022
hezhangjian
approved these changes
Feb 15, 2022
Member
Author
|
/pulsarbot rerun-failure-checks |
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiSubscriptionTest.java
Outdated
Show resolved
Hide resolved
nodece
force-pushed
the
fix_NPM_skip_message
branch
from
702714a to
a43a9e7
Compare
Demogorgon314
approved these changes
Feb 15, 2022
RobertIndie
approved these changes
Feb 15, 2022
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
fix_NPM_skip_message
branch
from
a43a9e7 to
fda4bbf
Compare
codelipenghui
approved these changes
Feb 15, 2022
merlimat
approved these changes
Feb 15, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zixuan Liu nodeces@gmail.com
Motivation
This issue was triggered by #14045, it did not handle the NPE.
Modifications
checkNotNull()Verifying this change
Documentation
no-need-doc