[Function] The incrCounter method should wait it done #14354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hezhangjian
approved these changes
Feb 17, 2022
Member
Author
|
/pulsarbot rerun-failure-checks |
Contributor
|
CI failed with @Demogorgon314 related with |
Member
Author
|
@gaozhangmin I see, this is another problem. thanks for telling me, I'll fix it soon. |
gaozhangmin
approved these changes
Feb 18, 2022
codelipenghui
requested review from
freeznet,
jerrypeng,
merlimat and
srkukarni
BewareMyPower
approved these changes
Feb 18, 2022
freeznet
approved these changes
Feb 18, 2022
Member
Author
|
@gaozhangmin #14373 PTAL : ) |
codelipenghui
pushed a commit
that referenced
this pull request
Mar 1, 2022
(cherry picked from commit afae29f)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14219
Motivation
The
incrCountermethod is a sync method, we should wait for it done.Modifications
Wait
incrCounterAsyncdone inincrCountermethod.Documentation
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-docThis is a bug fix, no need docs.
doc(If this PR contains doc changes)