Remove invalid Netty system property io.netty.recycler.maxCapacity.default which was renamed in 2014 #14576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4.1.x - see netty/netty@9fe97103 which renamed the property and current implementation in https://github.com/netty/netty/blob/51eda20432568ffdf736a673abc6b5a44839413f/common/src/main/java/io/netty/util/Recycler.java#L62-L90
lhotari
added
type/bug
HQebupt
approved these changes
Mar 7, 2022
nicoloboschi
approved these changes
Mar 7, 2022
Member
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
io.netty.recycler.maxCapacity.defaulttoio.netty.recycler.maxCapacityin 2014 for netty-4.1.0.Beta1io.netty.recycler.maxCapacityPerThreadas the primary setting and falls back toio.netty.recycler.maxCapacityModifications
-Dio.netty.recycler.maxCapacity.default=1000settings since there has been no impact of this setting. It would be a breaking change to set the correct setting to the value of 1000. Therefore it's better to simply drop the invalid property name.