Fixed 404 error msg not being returned correctly using http lookup.

[Technoboy-]

Motivation

When returning a 404 error using http-lookup, it doesn't prompt the correct message to user. below is a demo:

@Test
public void testHttpLookupWithNotFoundError() throws Exception {
     # Try to create a topic before namespace is created
     pulsarClient.newProducer().topic("unknownTenant/unknownNamespace/testNamespaceNotFound").create();
}

It will throw :

org.apache.pulsar.client.api.PulsarClientException$NotFoundException: Not found: Not Found

In this case, we should return Not found: Namespace not found.

The root cause is : when HTTP lookup with 404, we get the message from StatusText.

pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/HttpClient.java

Lines 206 to 216 in d02bd73

	if (response2.getStatusCode() != HttpURLConnection.HTTP_OK) {
	log.warn("[{}] HTTP get request failed: {}", requestUrl, response2.getStatusText());
	Exception e;
	if (response2.getStatusCode() == HttpURLConnection.HTTP_NOT_FOUND) {
	e = new NotFoundException("Not found: " + response2.getStatusText());
	} else {
	e = new PulsarClientException("HTTP get request failed: " + response2.getStatusText());
	}
	future.completeExceptionally(e);
	return;
	}

But we only set status,no statusText in RestException:

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/web/RestException.java

Lines 51 to 53 in d02bd73

	public RestException(int code, String message) {
	super(message, Response.status(code).entity(new ErrorData(message)).type(MediaType.APPLICATION_JSON).build());
	}

Documentation

• no-need-doc

[nodece]

LGTM