[fix][test] Fix flaky test LeaderElectionTest #14776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs? |
gaozhangmin
changed the title
|
@gaozhangmin:Thanks for providing doc info! |
gaozhangmin
changed the title
codelipenghui
approved these changes
Mar 21, 2022
codelipenghui
changed the title
Demogorgon314
approved these changes
Mar 21, 2022
Contributor
Author
|
/pulsarbot run-failure-checks |
Technoboy-
approved these changes
Mar 21, 2022
RobertIndie
approved these changes
Mar 21, 2022
Contributor
Author
|
/pulsarbot run-failure-checks |
Member
|
Please rebase onto the master branch to resolve the compile issue. |
gaozhangmin
force-pushed
the
fix-flakytest-LeaderElectionTest
branch
from
3bad9ac to
ec42cfc
Compare
Jason918
approved these changes
Mar 22, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Mar 25, 2022
(cherry picked from commit 46886b0)
codelipenghui
pushed a commit
that referenced
this pull request
Apr 19, 2022
(cherry picked from commit 46886b0)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14771
Motivation
flaky test LeaderElectionTest
Modifications
getLeaderValueIfPresentinvokegetIfCachedmethod. It's the same problem with #14373.Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)