[fix][test] Fix wrong retry behavior in MetadataCacheTest #14778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
force-pushed
the
fix/wrong-retry-behavior
branch
from
f6c2423 to
53bb047
Compare
codelipenghui
approved these changes
Mar 21, 2022
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataCacheTest.java
Show resolved
Hide resolved
Technoboy-
approved these changes
Mar 21, 2022
Member
Author
|
/pulsarbot run-failure-checks |
codelipenghui
pushed a commit
that referenced
this pull request
Mar 25, 2022
(cherry picked from commit f890017)
codelipenghui
added
cherry-picked/branch-2.9
codelipenghui
pushed a commit
that referenced
this pull request
Apr 19, 2022
(cherry picked from commit f890017)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when the retry count reaches to end, the
assertEqualsAndRetrymethod is always successful, we should remove this check.Modifications
Fix wrong retry behavior in MetadataCacheTest
Documentation
no-need-doc