[fix][broker] Reject auto create partitioned topic when topic name contains -partition-

[mattisonchao]

Motivation

When the user set config as follow:

{
    allowAutoTopicCreation: true,
    allowAutoTopicCreationType: "partitioned",
    defaultNumPartitions: 1
}

they can create partitioned topic success with topic name persistent://prop/autoNs/failedcreate-partition-abcde.

run get-partitioned-topic-metadata

{
  "partitions" : 1
}

run admin.topics().deletePartitionedTopic(topicName);

Partitioned Topic Name should not contain '-partition-'

run admin.topics().delete(topicName)

this operation can success delete the topic, but metadata still exists.

Modifications

Describe the modifications you've done.

Verifying this change

• Make sure that the change passes the CI checks.

Add TCP/HTTP client test for this change.

Documentation

• no-need-doc

[mattisonchao]

@Technoboy- @AnonHxy PTAL :)

[AnonHxy]

LGTM

[Jason918]

I think it's better to narrow the limitation to ends with -partition-\d+

[Jason918]

I think it's better to narrow the limitation to ends with -partition-\d+

@mattisonchao What do you think about this?

[mattisonchao]

I think it's better to narrow the limitation to ends with -partition-\d+

@mattisonchao What do you think about this?

@Jason918
I'm sorry for omitting this message, I think it's a great idea.

[mattisonchao]

Hi, @Jason918
I use topicName.getLocalName() to solve the problem you mentioned. PTAL:)

[Jason918]

LGTM

[mattisonchao]

/pulsarbot rerun-failure-checks

[mattisonchao]

/pulsarbot rerun-failure-checks

[codelipenghui]

@mattisonchao It might introduce a breaking change for DLQ, please help check the topic auto-creation with partitioned topic can work with DLQ with this change.

[mattisonchao]

Yes, We have to revert this PR and start a discussion in the mail list to find another graceful method.