-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][admin] Put validateTopicOwnershipAsync before validateTopicOperationAsync
#15265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
validateTopicOwnershipAsync before validateTopicOperationAsyncvalidateTopicOwnershipAsync before validateTopicOperationAsync
@Technoboy- please improve the description. What does this mean? It looks like this is an improvement for a recent change #15120. It would be worth cross-referencing that in the description to provide more context. |
Yes, it's one of the patches. |
Please be more specific and reference the other patches if you have that information. One reason why this is important is when someone is cherry-picking one of those patches, they know that the patch isn't complete and should include this change. It's better to provide more context in pull request descriptions since reviewers need the context information for reviewing the PR. Every reviewer has to lookup the context on their own if you don't provide it. That's a major waste of time which could easily be eliminated by providing better descriptions and more context. |
Yes, agree. I will update the description later. |
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work @Technoboy-
apache#15265) (cherry picked from commit 41f40f0) (cherry picked from commit 90caa1c)
Motivation
Maybe for mistake or other reason, some patches have put
validateTopicOperationAsyncfirst thenvalidateTopicOwnershipAsync. Related patches : #13880, #13878, #14045, #15120, #13845, #13805If the topic ownership does not belong to this broker, it will redirect to another broker, and
validateTopicOperationAsyncis useless in this case. so we should putvalidateTopicOwnershipAsyncbeforevalidateTopicOperationAsync.Documentation
no-need-doc