[cleanup][tx] Cleanup TransactionMetadataStoreService. #15286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@lhotari Could you please help review the removal of |
congbobo184
approved these changes
Apr 24, 2022
Technoboy-
force-pushed
the
cleanup-tx-metadata-store
branch
from
2507786 to
7ff1a16
Compare
Technoboy-
added
type/cleanup
liangyepianzhou
approved these changes
Apr 25, 2022
codelipenghui
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As #11357 has introduced
Transaction coordinator fence mechanismto implement TC instead ofBundle Listener, the old logic in the #TransactionMetadataStoreService#start has deprecated since 2.9. So it's better to remove them.Remove the unnecessary
synchronizedin the close method introduced by #14524.Modifications
startmethod.synchronizedin close.isRetryableException.Documentation
no-need-doc(Please explain why)