Skip to content

Conversation

@Jason918
Copy link
Contributor

Motivation

UsageUnit.Kbps.convertUnit is always 0. We should use double.

Modifications

Change int to double.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • LinuxInfoUtilsTest

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • no-need-doc
    bug fix.

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 26, 2022
@Jason918
Copy link
Contributor Author

@Technoboy- Technoboy- changed the title [broker] fix precision error in UsageUnit [fix][broker] fix precision error in UsageUnit Apr 26, 2022
@Technoboy- Technoboy- added area/broker type/bug The PR fixed a bug or issue reported a bug release/2.9.3 release/2.10.1 labels Apr 26, 2022
@Technoboy- Technoboy- added this to the 2.11.0 milestone Apr 26, 2022
@Jason918
Copy link
Contributor Author

/pulsarbot run-failure-checks

@Technoboy- Technoboy- merged commit 230d4a1 into apache:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/broker doc-not-needed Your PR changes do not impact docs type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants