Skip to content

Conversation

@kimula
Copy link
Contributor

@kimula kimula commented Apr 27, 2022

Motivation

protobuf 3.3.0 is vulnerable.
https://snyk.io/vuln/pip:protobuf

Modifications

upgrade the version of protobuf in pulsar-client-cpp to 3.20.0.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • no-need-doc

@kimula kimula force-pushed the fix-upgrade-protobuf branch from 9414174 to 2d803ab Compare April 27, 2022 08:09
@kimula kimula force-pushed the fix-upgrade-protobuf branch from 2d803ab to aa64dc1 Compare April 27, 2022 08:24
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 27, 2022
@kimula kimula marked this pull request as ready for review April 27, 2022 08:36
@BewareMyPower
Copy link
Contributor

/home/runner/work/pulsar/pulsar/pulsar-client-cpp
bash: line 1: /opt/cmake/cmake-3.20.0.0-Linux-x86_64/bin/cmake: No such file or directory

Could you verify the Dockerfile locally before pushing the patch? It looks like we shouldn't modify the path to cmake.

@kimula
Copy link
Contributor Author

kimula commented May 12, 2022

@BewareMyPower I undid an unneccessary change of cmake. PTAL.

@BewareMyPower BewareMyPower merged commit 8fdec2f into apache:master May 12, 2022
@kimula kimula deleted the fix-upgrade-protobuf branch May 16, 2022 08:37
zymap added a commit to zymap/pulsar that referenced this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants