Skip to content

Conversation

@heesung-sohn
Copy link
Contributor

@heesung-sohn heesung-sohn commented Apr 29, 2022

Master Issue: #15207

Motivation

  • As per the Java build 17 upgrade work, KinesisSink's default aggregation is exposed in the KinesisSinkTester. We need to cover this record aggregation behavior in the test.

Modifications

  • Updated the KinesisSinkTester to deaggregate response records, if aggregated.

Verifying this change

  • [] Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as PulsarSinksTest#testKinesis.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • no-need-doc
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-added
    (Docs have been already added)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 29, 2022
@merlimat merlimat added this to the 2.11.0 milestone Apr 29, 2022
@merlimat merlimat merged commit fc0da4c into apache:master Apr 30, 2022
@heesung-sohn heesung-sohn deleted the kinesis-sink-test branch April 2, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants