Skip to content

Conversation

@nicoloboschi
Copy link
Contributor

Motivation

Locally this test fails in this way (both on master and branch-2.10).

java.lang.AssertionError: expected [Unauthorized to validateNamespaceOperation for operation [GET_BUNDLE] on namespace [p1/global/ns1]] but found [Unauthorized to validateNamespaceOperation for operation [GET_TOPICS] on namespace [p1/global/ns1]]
	at org.testng.Assert.fail(Assert.java:99)
	at org.testng.Assert.failNotEquals(Assert.java:1037)
	at org.testng.Assert.assertEqualsImpl(Assert.java:140)
	at org.testng.Assert.assertEquals(Assert.java:122)
	at org.testng.Assert.assertEquals(Assert.java:629)
	at org.testng.Assert.assertEquals(Assert.java:639)
	at org.apache.pulsar.broker.auth.AuthorizationTest.testGetListWithoutGetBundleOp(AuthorizationTest.java:255)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

I didn't get how this could be mergeable when we merged the related pull (#14638) or if it is failing on CI since it is under the flaky group.

Modifications

  • Added the right error message check
  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 9, 2022
@Technoboy-
Copy link
Contributor

Hi @nicoloboschi
I have pushed #15501 to fix the authorization and related test.

@nicoloboschi
Copy link
Contributor Author

@Technoboy- thanks. closing this one

@nicoloboschi nicoloboschi deleted the fix-test-auth branch May 9, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants