-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][ci] Fix tests memory leak due to mockito-inline #15513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][ci] Fix tests memory leak due to mockito-inline #15513
Conversation
(cherry picked from commit fd01f9e)
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot rerun-failure-checks |
eolivelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch
|
/pulsarbot rerun-failure-checks |
1 similar comment
|
/pulsarbot rerun-failure-checks |
|
@nicoloboschi Are the tests more flaky after this change or are there real failures? I wonder if the classloading works correctly for Mockito if reflection isn't used in a TestNG listener? |
f6b14c7 to
43731ec
Compare
I believe they are flaky as always. I addressed the let me re-run the tests |
|
/pulsarbot rerun-failure-checks |
|
it is better to merge #15638 before this one. then rebase and re-run the checks to see everything is green |
|
This fix is important for stabilizing our CI. My assumption is that it would fix the strange issue #15689 where Mocks from another test are leaked into that test. |
|
/pulsarbot rerun-failure-checks |
(cherry picked from commit 14b95ec)
Motivation
I noticed an increased memory usage in long-running process which run the unit broker tests. After investigating I found out the introduction of mockito-inline is the culprit.
In the documentation is specified that it this behaviour is possible and there's a way to fix it
Modifications
no-need-doc