[improve][broker] Make some methods in NamespacesBase async. #15518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
added
type/enhancement
26 tasks
Technoboy-
force-pushed
the
namespace-async-1
branch
from
c35afe5 to
a553d73
Compare
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
Show resolved
Hide resolved
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/TenantResources.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
May 11, 2022
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/TenantResources.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
May 11, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Show resolved
Hide resolved
mattisonchao
approved these changes
May 13, 2022
Member
mattisonchao
left a comment
mattisonchao
left a comment
There was a problem hiding this comment.
LGTM, Left some minor comments.
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/TenantResources.java
Outdated
Show resolved
Hide resolved
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/TenantResources.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
Technoboy-
force-pushed
the
namespace-async-1
branch
from
392d21e to
0c8810c
Compare
codelipenghui
approved these changes
May 14, 2022
Member
|
there seem to be a new type of failure in tests causing flakiness and it could be related to this PR. Please check #15652 |
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
May 18, 2022
…pache#15518)" This reverts commit 138ea35.
26 tasks
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Apr 27, 2025
…15518) ### Motivation See PIP apache#14365 and change tracker apache#15043. Make `NamespacesBase` `getTenantNamespaces / createNamespace / getTopics / getPolicies / getPermissions` methods to pure async. (cherry picked from commit 138ea35) Signed-off-by: Zixuan Liu <nodeces@gmail.com> # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminTest.java # pulsar-broker/src/test/java/org/apache/pulsar/broker/auth/MockedPulsarServiceBaseTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See PIP #14365 and change tracker #15043.
Make
NamespacesBasegetTenantNamespaces / createNamespace / getTopics / getPolicies / getPermissionsmethods to pure async.Documentation
no-need-doc(Please explain why)