[cleanup][broker] Override close method to avoid caching exception. #15529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
added
type/cleanup
Technoboy-
requested review from
eolivelli,
lhotari and
michaeljmarshall
and removed request for
michaeljmarshall
michaeljmarshall
approved these changes
May 11, 2022
mattisonchao
approved these changes
May 11, 2022
codelipenghui
approved these changes
May 11, 2022
2 tasks
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 23, 2022
…pache#15529) (cherry picked from commit 526979a) (cherry picked from commit e3add83)
mattisonchao
added
release/2.9.3
cherry-picked/branch-2.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#10384 has defined PublishRateLimiter to extend AutoCloseable, but its
closemethod will throw exception, cause to cache it when updating the limiter.I think we can override
closemethod to avoid catching the exception everywhere.Documentation
no-need-doc(Please explain why)