Skip to content

[improve][broker] Avoid using synchronous operations in the async method to block metadata threads. #15557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattisonchao wants to merge 3 commits into from
Closed

[improve][broker] Avoid using synchronous operations in the async method to block metadata threads. #15557

mattisonchao wants to merge 3 commits into from

Conversation

@mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented May 12, 2022 •
edited
Loading

Fixes #15549

Master Issue: #15549

Motivation

See #15549

Modifications

  • Use validateTopicOperationAsync instead of checkAuthorization method and make it pure async.
  • Refactor code to make it more readable.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 12, 2022
@mattisonchao
Copy link
Member Author

mattisonchao commented May 12, 2022

@leizhiyuan Please take a look, thanks!

@Technoboy- Technoboy- changed the title [Fix][Proxy] Avoid using synchronous operations in the async method to block metadata threads. [improve][broker] Avoid using synchronous operations in the async method to block metadata threads. May 12, 2022
@Technoboy- Technoboy- added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker labels May 12, 2022
@Technoboy- Technoboy- added this to the 2.11.0 milestone May 12, 2022
@mattisonchao
Copy link
Member Author

mattisonchao commented May 21, 2022

#15694 Has been fixed this issue. So, close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eolivelli eolivelli Awaiting requested review from eolivelli

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

@gaoran10 gaoran10 Awaiting requested review from gaoran10

@merlimat merlimat Awaiting requested review from merlimat

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

1 more reviewer

@leizhiyuan leizhiyuan leizhiyuan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mattisonchao mattisonchao

Labels

area/broker doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

metadata-store thread will running too long and occurs timeout of admin api when allowTopicOperation

3 participants

@mattisonchao @leizhiyuan @Technoboy-