[optimize][txn] Optimize transaction lowWaterMark to clean useless data faster #15592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta faster ### Motivation The current implementation mechanism of low water mark is to make a judgment after the end transaction, and only for the first transaction in ongoingTxns. This makes useless data cleaning very slow. ### Modification Store lowWaterMark for tc in TB and TP. Recursively calls lowWaterMark and cleans the data according to the stored lowWaterMarks
congbobo184
requested review from
codelipenghui,
congbobo184,
eolivelli,
gaoran10 and
mattisonchao
congbobo184
reviewed
May 16, 2022
...r/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/apache/pulsar/broker/transaction/buffer/TransactionLowWaterMarkTest.java
Show resolved
Hide resolved
congbobo184
reviewed
May 17, 2022
.../src/test/java/org/apache/pulsar/broker/transaction/pendingack/PendingAckPersistentTest.java
Show resolved
Hide resolved
congbobo184
approved these changes
May 17, 2022
Contributor
Author
|
/pulsarbot run-failure-checks |
Technoboy-
reviewed
May 19, 2022
...r/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
Show resolved
Hide resolved
Contributor
Author
|
/pulsarbot run-failure-checks |
5 tasks
Technoboy-
approved these changes
May 20, 2022
mattisonchao
added
release/2.9.3
cherry-picked/branch-2.9
nicoloboschi
added a commit
to nicoloboschi/pulsar
that referenced
this pull request
May 26, 2022
…eless data faster (apache#15592)" This reverts commit 033a3b6.
codelipenghui
pushed a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
Jun 7, 2022
…ta faster (apache#15592) (cherry picked from commit fcf5e14)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2022
…ta faster (apache#15592) (cherry picked from commit fcf5e14) (cherry picked from commit fa78cf8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation mechanism of low water mark is to make a judgment after the end transaction, and only for the first transaction in ongoingTxns.
This makes useless data cleaning very slow.
Modification
Store lowWaterMark for tc in TB and TP.
Recursively calls lowWaterMark and cleans the data according to the stored lowWaterMarks
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
no-need-doc(Please explain why)
doc(Your PR contains doc changes)
doc-added(Docs have been already added)