[improve][broker] Make some operation auto topic creation in Namespaces async. #15621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
changed the title
Technoboy-
reviewed
May 18, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Show resolved
Hide resolved
Technoboy-
reviewed
May 18, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Show resolved
Hide resolved
Technoboy-
reviewed
May 18, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Show resolved
Hide resolved
Technoboy-
reviewed
May 18, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Outdated
Show resolved
Hide resolved
Technoboy-
reviewed
May 18, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Show resolved
Hide resolved
Technoboy-
reviewed
May 18, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Show resolved
Hide resolved
Technoboy-
reviewed
May 18, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Show resolved
Hide resolved
Technoboy-
reviewed
May 18, 2022
| internalSetAutoTopicCreationAsync(null) | ||
| .thenAccept(__ -> { | ||
| log.info("[{}] Successfully remove autoTopicCreation on namespace {}", clientAppId()); | ||
| asyncResponse.resume(Response.noContent().build()); |
Contributor
There was a problem hiding this comment.
log.info("[{}] Successfully remove autoTopicCreation on namespace {}", clientAppId()) ->
log.info("[{}] Successfully remove autoTopicCreation on namespace {}", clientAppId(), namespaceName);
Member
Author
|
@Technoboy- Thanks for your review. Fixed, PTAL. |
Technoboy-
approved these changes
May 19, 2022
Technoboy-
added
type/enhancement
Contributor
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
May 19, 2022
Member
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot run-failure-checks |
Member
nodece
requested changes
May 24, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Show resolved
Hide resolved
Member
Author
|
@mattisonchao @nodece Thanks for your review. Sorry, I miss the change of #15653 when rebasing. All suggest fixed, Please help review again. |
nodece
approved these changes
May 25, 2022
26 tasks
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See PIP #14365 and change tracker #15043.
Make NamespacesBase
getAutoTopicCreation / setAutoTopicCreation / removeAutoTopicCreationmethods to pure async.Documentation
no-need-doc(Please explain why)