[Revert] [#15483] Remove sensitive msg from consumer/producer stats log #15817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hezhangjian
requested review from
RobertIndie,
Technoboy-,
codelipenghui and
michaeljmarshall
RobertIndie
approved these changes
May 27, 2022
coderzc
approved these changes
May 28, 2022
Member
Author
|
/pulsarbot run-failure-checks |
added 2 commits
June 3, 2022 08:56
codelipenghui
pushed a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
Jun 7, 2022
…tats log (apache#15817) ### Motivation See apache#15483 The `@Secret` annotation works well, and introduced in apache#8910 ### Modifications - Revert the unneeded `@JsonIgnore` - remove `Assert.assertFalse(s.contains("Password"));` `Password` is printed in a key. The sensitive field's value is `****`. (cherry picked from commit 67361e8)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2022
…tats log (apache#15817) ### Motivation See apache#15483 The `@Secret` annotation works well, and introduced in apache#8910 ### Modifications - Revert the unneeded `@JsonIgnore` - remove `Assert.assertFalse(s.contains("Password"));` `Password` is printed in a key. The sensitive field's value is `****`. (cherry picked from commit 67361e8) (cherry picked from commit f8bc91f)
codelipenghui
pushed a commit
that referenced
this pull request
Jun 10, 2022
…og (#15817) ### Motivation See #15483 The `@Secret` annotation works well, and introduced in #8910 ### Modifications - Revert the unneeded `@JsonIgnore` - remove `Assert.assertFalse(s.contains("Password"));` `Password` is printed in a key. The sensitive field's value is `****`. (cherry picked from commit 67361e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #15483
The
@Secretannotation works well, and introduced in #8910Modifications
@JsonIgnoreAssert.assertFalse(s.contains("Password"));Passwordis printed in a key. The sensitive field's value is****.