[fix][txn]Fix transasction ack batch message #15875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
requested review from
Jason918,
Technoboy-,
codelipenghui,
congbobo184,
eolivelli,
gaoran10 and
mattisonchao
congbobo184
added
type/bug
congbobo184
approved these changes
Jun 2, 2022
congbobo184
requested changes
Jun 2, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/pulsarbot run-failure-checks |
congbobo184
approved these changes
Jun 7, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Jun 7, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2022
Fixes apache#15832 ### Motivation The transaction needs batch size to help determine whether the batch message is in the pending ack state. ### Modifications Returns the batch size of messageID directly. (cherry picked from commit f87b370) (cherry picked from commit 2cd29dc)
codelipenghui
pushed a commit
that referenced
this pull request
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15832
Motivation
Transaction needs batch size to help determine whether the batch message is in the pending ack state.
Modifications
Returns the batch size of messageID directly.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)