[Tests] Fix OutOfMemoryError and NoClassDefFoundErrors in tests #15911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the PulsarByteBufAllocator.DEFAULT instance was replaced in BatchMessageContainerImplTest, but never restored
lhotari
requested review from
RobertIndie,
Technoboy-,
hezhangjian,
michaeljmarshall and
nicoloboschi
This was referenced Jun 2, 2022
dlg99
approved these changes
Jun 2, 2022
hezhangjian
approved these changes
Jun 3, 2022
lhotari
added a commit
that referenced
this pull request
Jun 6, 2022
Fixes #15689 Fixes #15793 Fixes #15897 ### Motivation `PulsarByteBufAllocator.DEFAULT` instance was replaced in BatchMessageContainerImplTest, but never restored. This caused strange issues in many unit tests. OutOfMemoryError and NoClassDefFoundErrors were most likely caused by the BatchMessageContainerImplTest. ### Modifications Fix the problems in BatchMessageContainerImplTest and reset the state after the test completes. ### Additional context The flaky test was introduced by #12170 which has been cherry-picked to branch-2.8, branch-2.9 and included also in branch-2.10 . (cherry picked from commit ef1e0aa)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 6, 2022
…he#15911) Fixes apache#15689 Fixes apache#15793 Fixes apache#15897 ### Motivation `PulsarByteBufAllocator.DEFAULT` instance was replaced in BatchMessageContainerImplTest, but never restored. This caused strange issues in many unit tests. OutOfMemoryError and NoClassDefFoundErrors were most likely caused by the BatchMessageContainerImplTest. ### Modifications Fix the problems in BatchMessageContainerImplTest and reset the state after the test completes. ### Additional context The flaky test was introduced by apache#12170 which has been cherry-picked to branch-2.8, branch-2.9 and included also in branch-2.10 . (cherry picked from commit ef1e0aa) (cherry picked from commit 3f3d452)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15689
Fixes #15793
Fixes #15897
Motivation
PulsarByteBufAllocator.DEFAULTinstance was replaced in BatchMessageContainerImplTest, but never restored. This caused strange issues in many unit tests. OutOfMemoryError and NoClassDefFoundErrors were most likely caused by the BatchMessageContainerImplTest.Modifications
Fix the problems in BatchMessageContainerImplTest and reset the state after the test completes.
Additional context
The flaky test was introduced by #12170 which has been cherry-picked to branch-2.8, branch-2.9 and included also in branch-2.10 .