Support shrink for TripleLongPriorityQueue #15936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Jun 5, 2022
Contributor
merlimat
left a comment
merlimat
left a comment
There was a problem hiding this comment.
This is already a nice improvement (provided we assure the memory is released correctly :) ).
A further improvement could be to consider the priority queue as composed of "segments", where each segment is a ByteBuf. When the queue shrinks and the size goes below a segment threshold, we can just remove the buffer, without any resizing.
...-common/src/main/java/org/apache/pulsar/common/util/collections/TripleLongPriorityQueue.java
Outdated
Show resolved
Hide resolved
...-common/src/main/java/org/apache/pulsar/common/util/collections/TripleLongPriorityQueue.java
Outdated
Show resolved
Hide resolved
merlimat
added
the
type/enhancement
Jason918
reviewed
Jun 6, 2022
...-common/src/main/java/org/apache/pulsar/common/util/collections/TripleLongPriorityQueue.java
Outdated
Show resolved
Hide resolved
merlimat
approved these changes
Jun 6, 2022
merlimat
pushed a commit
that referenced
this pull request
Jul 12, 2022
* Support shrinkage in TripleLongPriorityQueue * Add unit test * Remove unused code * style * Address comments
merlimat
pushed a commit
that referenced
this pull request
Jul 12, 2022
* Support shrinkage in TripleLongPriorityQueue * Add unit test * Remove unused code * style * Address comments
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 13, 2022
* Support shrinkage in TripleLongPriorityQueue * Add unit test * Remove unused code * style * Address comments (cherry picked from commit 88b10e0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support shrinkage in TripleLongPriorityQueue. Avoid memory waste.
Modifications
When the actual memory usage is less than the threshold, scale down.
Since the thresholds for expansion and contraction may be the same, in order to avoid frequent expansion and contraction, a 10% buffer is reserved.
Verifying this change
Verify that it can shrink normally
Documentation
doc-not-neededIt is a internal class