[fix][tests] TieredStorageConfigurationTests - clear system properties #15957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
added
doc-not-needed
Technoboy-
approved these changes
Jun 7, 2022
nicoloboschi
requested changes
Jun 7, 2022
| assertEquals(properties.get("jclouds.region"), "jclouds-region"); | ||
| assertEquals(config.getServiceEndpoint(), "http://localhost"); | ||
| assertEquals(properties.get("jclouds.SystemPropertyA"), "A"); | ||
| System.clearProperty("jclouds.SystemPropertyA"); |
Contributor
There was a problem hiding this comment.
better to do that in a finally block
zymap
approved these changes
Jun 9, 2022
Jason918
reviewed
Jun 11, 2022
...a/org/apache/bookkeeper/mledger/offload/jcloud/provider/TieredStorageConfigurationTests.java
Outdated
Show resolved
Hide resolved
Jason918
approved these changes
Jun 21, 2022
nicoloboschi
approved these changes
Jun 21, 2022
Contributor
Author
|
/pulsarbot rerun-failure-checks |
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 4, 2022
apache#15957) (cherry picked from commit bacc9d6) (cherry picked from commit 2198c33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This PR #15710 introduced a new test case that set some system properties without clearing them.
Modification:
clean up the env, in order to not pollute the execution of the other tests
doc-not-needed