[fix][admin] Fix get non-persistent topics issue in Namespaces. #16170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Jun 23, 2022
codelipenghui
added
the
release/important-notice
eolivelli
requested changes
Jun 23, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Outdated
Show resolved
Hide resolved
Technoboy-
changed the title
Technoboy-
changed the title
Technoboy-
force-pushed
the
fix-namespace-get-topic-issue
branch
from
ef72aae to
5791c78
Compare
Member
|
Hi @Technoboy- It looks like we have some conflict with branch-2.9. Could you please help cherry-pick it? |
Contributor
|
@Technoboy- Please also help cherry-pick to branch-2.10. |
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Jul 11, 2022
2 tasks
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Jul 11, 2022
2 tasks
Contributor
Author
Yes, done. #16517 |
Contributor
Author
Ok, done. #16514 |
Technoboy-
added
cherry-picked/branch-2.9
Technoboy-
added a commit
that referenced
this pull request
Jul 11, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 11, 2022
…ache#16514) (cherry picked from commit 22ae18b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #16081
Motivation
Currently, we can use
admin.namespaces().getTopicsto get topics under a namespace. But it could only return the non-persistent topics owned by the current broker.Also, we can use
admin.toipics().getListto get topics. It can return all non-persistent topics to users.I think it is reasonable that we should make the data return of these two interfaces consistent.
Verifying this change
Documentation
doc-not-needed(Please explain why)