-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[client][c++] add getLastMessageIdAsync in Consumer #16182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[client][c++] add getLastMessageIdAsync in Consumer #16182
Conversation
|
@komalatammal Please provide a correct documentation label for your PR. |
|
@BewareMyPower we need 2 bindings +1 in order to commit a patch. |
|
Okay. Got it. |
|
@eolivelli But I have a concern that should it be a strict constraint or a blocker? Or how long should we wait if no one has time to review or doesn't want to review? I'm afraid currently there are not enough reviewers for all PRs. For example, #16072 is another PR I've merged with only 1 binding +1. But no one reviewed this PR in 5 days after it's opened, though I've pinged reviewers again. |
|
yes, it is a strict constraint for all non-trivial changes. if you want to sponsor a patch the best way is to send a message to dev@ and ask for a second reviewer. 5 days it not much time in a OSS community, we have to keep in mind that committers are volunteers. |
|
Okay, I'll keep it in mind next time. |
@eolivelli - I did not realize this was a strict requirement. Have we discussed this on the dev mailing list recently? It might be worth re-iterating the requirement. It might also be worth documenting here: https://github.com/apache/pulsar/wiki/Committer-Guide. |
* python cc binding for getLastMessageId * add python Consumer class method and doc * fix linter issues based on clang-format * ubuntu linter fix * try run unit test in ci * fix doc comment * test the test case can be ran ### Motivation Python function getLastMessageId It is a C binding for #16182 to implement get_last_message_id() in Python client. ### Modifications Add Python/C binding code for get_last_message_id() ### Verifying this change It compiles. - [x] Make sure that the change passes the CI checks. This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (yes) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation Check the box below or label this PR directly. Need to update docs? - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [ ] `doc-not-needed` - [x] `doc` Python Doc is updated in __init__.py - [ ] `doc-complete` (Docs have been already added)
* python cc binding for getLastMessageId * add python Consumer class method and doc * fix linter issues based on clang-format * ubuntu linter fix * try run unit test in ci * fix doc comment * test the test case can be ran ### Motivation Python function getLastMessageId It is a C binding for #16182 to implement get_last_message_id() in Python client. ### Modifications Add Python/C binding code for get_last_message_id() ### Verifying this change It compiles. - [x] Make sure that the change passes the CI checks. This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (yes) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation Check the box below or label this PR directly. Need to update docs? - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [ ] `doc-not-needed` - [x] `doc` Python Doc is updated in __init__.py - [ ] `doc-complete` (Docs have been already added)
* python cc binding for getLastMessageId * add python Consumer class method and doc * fix linter issues based on clang-format * ubuntu linter fix * try run unit test in ci * fix doc comment * test the test case can be ran ### Motivation Python function getLastMessageId It is a C binding for apache#16182 to implement get_last_message_id() in Python client. ### Modifications Add Python/C binding code for get_last_message_id() ### Verifying this change It compiles. - [x] Make sure that the change passes the CI checks. This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (yes) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation Check the box below or label this PR directly. Need to update docs? - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [ ] `doc-not-needed` - [x] `doc` Python Doc is updated in __init__.py - [ ] `doc-complete` (Docs have been already added)
* python cc binding for getLastMessageId * add python Consumer class method and doc * fix linter issues based on clang-format * ubuntu linter fix * try run unit test in ci * fix doc comment * test the test case can be ran ### Motivation Python function getLastMessageId It is a C binding for apache/pulsar#16182 to implement get_last_message_id() in Python client. ### Modifications Add Python/C binding code for get_last_message_id() ### Verifying this change It compiles. - [x] Make sure that the change passes the CI checks. This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (yes) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation Check the box below or label this PR directly. Need to update docs? - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [ ] `doc-not-needed` - [x] `doc` Python Doc is updated in __init__.py - [ ] `doc-complete` (Docs have been already added)
Motivation
Add getLastMessageId method to C++ Consumer.cc to address the missing part in this PR #15993
Modifications
Expose methods to get last message Id in consumer, the C++ client's Consumer class
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)