[fix][broker] fix the incorrect swagger response parameter type#16189
Closed
Nicklee007 wants to merge 1 commit intoapache:masterfrom
Closed
[fix][broker] fix the incorrect swagger response parameter type#16189Nicklee007 wants to merge 1 commit intoapache:masterfrom
Nicklee007 wants to merge 1 commit intoapache:masterfrom
Conversation
HQebupt
reviewed
Jun 25, 2022
| @ApiOperation( | ||
| value = "Get the configuration for the specified cluster.", | ||
| response = ClusterDataImpl.class, | ||
| response = ClusterData.class, |
Contributor
There was a problem hiding this comment.
It does not seem a bug. Is there an error when calling the Api ?
Contributor
Author
There was a problem hiding this comment.
the function return POJO is ClusterData.class but set in swagger is ClusterDataImpl.class and also will show to user the incorrect return type. It will meet some error when we through restful api to invoke the method and want to transfer the result to ClusterData.class.
Contributor
Author
|
The pr had no activity for 30 days, mark with Stale label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
modify the incorrect swagger response parameter type in
ClustersBase.classModifications
modify the incorrect swagger response parameter type.
doc-not-needed