fix select broker is none #16316
Merged
fix select broker is none #16316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaozhangmin
approved these changes
Jul 1, 2022
gaozhangmin
reviewed
Jul 1, 2022
| getAvailableBrokers(), | ||
| brokerTopicLoadingPredicate); | ||
| broker = placementStrategy.selectBroker(brokerCandidateCache, data, loadData, conf); | ||
| Optional<String> brokerTmp = placementStrategy.selectBroker(brokerCandidateCache, data, loadData, conf); |
Contributor
There was a problem hiding this comment.
src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java:[881] (sizes) LineLength: Line is longer than 120 characters (found 124).
Please fix checkstyle violation
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
|
LGTM |
merlimat
approved these changes
Jul 1, 2022
mattisonchao
pushed a commit
that referenced
this pull request
Jul 2, 2022
* fix select broker is none * check style (cherry picked from commit cf4fe17)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Jul 5, 2022
* fix select broker is none * check style
codelipenghui
pushed a commit
that referenced
this pull request
Jul 10, 2022
* fix select broker is none * check style (cherry picked from commit cf4fe17)
wuxuanqicn
pushed a commit
to wuxuanqicn/pulsar
that referenced
this pull request
Jul 14, 2022
* fix select broker is none * check style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In selectBrokerForAssignment, when the broker is selected again, it is not judged whether the selected broker is empty.
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)