[improve][broker] Use shared broker client scheduled executor provider #16338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation apache#16334 supports passing scheduled executor to the client. Use a shared scheduled executor for the broker clients which used by replicator and system topics.
codelipenghui
added
type/enhancement
|
@codelipenghui Please provide a correct documentation label for your PR. |
github-actions
bot
added
doc-label-missing
doc-not-needed
Jason918
reviewed
Jul 2, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
Outdated
Show resolved
Hide resolved
…vice.java Co-authored-by: JiangHaiting <jason.918@qq.com>
poorbarcode
approved these changes
Jul 3, 2022
Contributor
poorbarcode
left a comment
poorbarcode
left a comment
There was a problem hiding this comment.
This PR will make multiple clients in the broker node share the same scheduled executor object. Lgtm.
michaeljmarshall
approved these changes
Jul 5, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 11, 2022
apache#16338) (cherry picked from commit 4dd4ba5) (cherry picked from commit 45fd4ab)
wuxuanqicn
pushed a commit
to wuxuanqicn/pulsar
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#16334 supports passing scheduled executor to the client. Use a shared scheduled executor
for the broker clients which used by replicator and system topics.
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)