Skip to content

Conversation

@momo-jun
Copy link
Contributor

@momo-jun momo-jun commented Jul 7, 2022

Modifications

  1. Add a note for destination-topic-name to clarify the usage and workaround. Note that the note needs to be removed as soon as topicName should not be a required config for source connector #15667 is resolved.

image

  1. Fix incorrect REST API links in 2.10.x. Related PR: [improve][doc] Add info for health check CMD and fix incorrect REST API links #16267; Related issue: [feat][website] REST API URL does not go to the correct place  #14928
  2. Other minor fixes.

Documentation

  • doc

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jul 7, 2022
@momo-jun momo-jun changed the title [improve][doc] Clarify the usage of destination-topic-name in Debezium connector [improve][doc] Clarify the usage of destination-topic-name for Debezium connector and fix incorrect REST API links Jul 8, 2022
@momo-jun momo-jun marked this pull request as ready for review July 8, 2022 11:19
@momo-jun
Copy link
Contributor Author

Ping @freeznet and @Huanli-Meng to review item#1.

Copy link
Contributor

@Huanli-Meng Huanli-Meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Huanli-Meng
Copy link
Contributor

@momo-jun could you help resolve the conflicts? Then, we can merge the PR. Thanks.

@momo-jun
Copy link
Contributor Author

@Anonymitaet this PR contains the fix to address the remaining anchoring issues of REST API links.

@momo-jun
Copy link
Contributor Author

@momo-jun could you help resolve the conflicts? Then, we can merge the PR. Thanks.

Resolved. Thank you.

@codelipenghui codelipenghui merged commit 840e920 into apache:master Jul 13, 2022
gaozhangmin pushed a commit to gaozhangmin/pulsar that referenced this pull request Jul 14, 2022
…zium connector and fix incorrect REST API links (apache#16433)
wuxuanqicn pushed a commit to wuxuanqicn/pulsar that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants