Skip to content

Conversation

@andrasbeni
Copy link
Contributor

TopicListWatchers need a ClientCnx to communicate to a broker, but they have no topic to discover the owner. So they rely on the lookup URL. When the scheme is HTTP, no ClientCnx can be created with it.

Modifications

  • Not creating a TopicListWatcher when HTTP URL is specified
  • Added a test to avoid future regressions in this area

Verifying this change

  • Make sure that the change passes the CI checks.

This change added a test

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no )
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below or label this PR directly.

Need to update docs?

Motivation

TopicListWatcher's can not work when the lookup url scheme is HTTP.

Changes

- Not creating a TopicListWatcher when HTTP url is specified
- Create test to avoid future regressions in this area
@Technoboy- Technoboy- added this to the 2.11.0 milestone Jul 14, 2022
@Technoboy- Technoboy- added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/client doc-not-needed Your PR changes do not impact docs labels Jul 14, 2022
@merlimat merlimat merged commit 9bdf494 into apache:master Jul 14, 2022
@andrasbeni andrasbeni deleted the TopicListWatcherFix branch August 8, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/client doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants