Avoid tracking the delays of all the message when we detect that they are fixed #16609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
addisonj,
codelipenghui,
hangc0276,
lhotari and
michaeljmarshall
merlimat
force-pushed
the
simpler-delay-track
branch
from
e5be9c0 to
8400204
Compare
codelipenghui
approved these changes
Jul 15, 2022
hangc0276
approved these changes
Jul 15, 2022
merlimat
added a commit
that referenced
this pull request
Jul 15, 2022
… are fixed (#16609) * Avoid tracking the delays of all the message when we detect that they are fixed * Use tick time to avoid clock skews across different producers
merlimat
added a commit
that referenced
this pull request
Jul 15, 2022
… are fixed (#16609) * Avoid tracking the delays of all the message when we detect that they are fixed * Use tick time to avoid clock skews across different producers
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 19, 2022
… are fixed (apache#16609) * Avoid tracking the delays of all the message when we detect that they are fixed * Use tick time to avoid clock skews across different producers (cherry picked from commit 871fe36)
2 tasks
15 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If all the messages in a topic have the same fixed delay, then there is no reason to track the entire set of messages in the priority queue, since the messages will have to be delivered in FIFO order.
If we identify that this is the case, we need to switch into a different mode, where we pause the scanning of the topic and instead we just rely on the timer task from the delay-tracker which will get triggered for the 1st message to be delivered.
doc-not-needed