[Java Client] Send CloseConsumer on client timeout #16616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
requested review from
codelipenghui,
congbobo184,
eolivelli,
lhotari and
nicoloboschi
michaeljmarshall
changed the title
github-actions
bot
added
the
doc
eolivelli
approved these changes
Jul 15, 2022
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
LGTM
we should port this to 2.10 and other active branches
hezhangjian
approved these changes
Jul 15, 2022
liudezhi2098
approved these changes
Jul 15, 2022
Member
Member
@michaeljmarshall were there other issues or was it only about a warning in the logs? |
lhotari
approved these changes
Jul 15, 2022
mattisonchao
approved these changes
Jul 16, 2022
nicoloboschi
approved these changes
Jul 17, 2022
Member
+1, and a question, what if the close consumer command times out? |
Contributor
|
closed/reopened to trigger CI |
codelipenghui
approved these changes
Jul 29, 2022
BewareMyPower
pushed a commit
that referenced
this pull request
Aug 2, 2022
(cherry picked from commit 8f31655)
Gleiphir2769
pushed a commit
to Gleiphir2769/pulsar
that referenced
this pull request
Aug 4, 2022
momo-jun
added a commit
to momo-jun/pulsar
that referenced
this pull request
Aug 5, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Aug 8, 2022
(cherry picked from commit 8f31655)
mattisonchao
pushed a commit
that referenced
this pull request
Aug 10, 2022
(cherry picked from commit 8f31655)
RobertIndie
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Jul 20, 2023
### Motivation This change is the same as apache/pulsar#13161 and apache/pulsar#16616, and is justified by these lines of our binary protocol spec: * https://github.com/apache/pulsar-site/blob/9b4b3d39014bd47c0bb9f66742b89bcb40ed7f07/docs/developing-binary-protocol.md?plain=1#L301-L304 * https://github.com/apache/pulsar-site/blob/9b4b3d39014bd47c0bb9f66742b89bcb40ed7f07/docs/developing-binary-protocol.md?plain=1#L468-L471 ### Modifications * When a producer or a consumer times out during creation, make an attempt to close the producer or consumer by sending the appropriate close command. Failures can safely be ignored because the only time that the close will actually matter is when the TCP connection is open for other protocol messages. The one nuance is that we send the close command to the same address pair that we send the create command.
RobertIndie
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Sep 7, 2023
### Motivation This change is the same as apache/pulsar#13161 and apache/pulsar#16616, and is justified by these lines of our binary protocol spec: * https://github.com/apache/pulsar-site/blob/9b4b3d39014bd47c0bb9f66742b89bcb40ed7f07/docs/developing-binary-protocol.md?plain=1#L301-L304 * https://github.com/apache/pulsar-site/blob/9b4b3d39014bd47c0bb9f66742b89bcb40ed7f07/docs/developing-binary-protocol.md?plain=1#L468-L471 ### Modifications * When a producer or a consumer times out during creation, make an attempt to close the producer or consumer by sending the appropriate close command. Failures can safely be ignored because the only time that the close will actually matter is when the TCP connection is open for other protocol messages. The one nuance is that we send the close command to the same address pair that we send the create command. (cherry picked from commit d4e08c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #13161 and #12948
Motivation
The current Java Client consumer code does not clean up a pending consumer on the server when the client's timeout expires. This creates problems when the client tries to recreate the consumer with a
Subscribecommand. In this case, we see warnings like the following:Modifications
CloseConsumercommand when theSubscribecommand times out from the client perspective.Verifying this change
This change includes new tests.
Does this pull request potentially affect one of the following parts:
This change introduces new recommendation for the Pulsar Protocol, but it does not make any breaking changes.
Note also that the C++ client already follows this behavior.
Documentation
doc