[fix][broker] Fix consumer does not abide by the max unacks limitation for Key_Shared subscription #16718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n for Key_Shared subscription
codelipenghui
added
type/bug
Technoboy-
approved these changes
Jul 21, 2022
shibd
approved these changes
Jul 21, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2022
…n for Key_Shared subscription (apache#16718) (cherry picked from commit fd9c418) (cherry picked from commit 0ab33bf)
2 tasks
dragonls
pushed a commit
to dragonls/pulsar
that referenced
this pull request
Oct 21, 2022
…n for Key_Shared subscription (apache#16718)
dragonls
pushed a commit
to dragonls/pulsar
that referenced
this pull request
Oct 21, 2022
…release' (merge request !67) branch-2.9-fix-somebug-key-share [fix][broker] Multiple consumer dispatcher stuck when unackedMessages greater than maxUnackedMessages (apache#17483) [fix][broker] Fix consumer does not abide by the max unacks limitation for Key_Shared subscription apache#16718 [fix][broker] Fix consumer does not abide by the max unacks limitation for Shared subscription apache#16670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A follow-up fix #16670
Verifying this change
Update the test testMaxUnAckMessagesLowerThanPermits for support Shared and Key_Shared subscription
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)