[fix][broker] Run sendMessagesToConsumers in the same thread by default #16807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation See apache#16802 and the discussion in apache#16803. Before reverting apache#16603, disabling the `dispatcherDispatchMessagesInSubscriptionThread` option first. ### Modifications Change the default value of `dispatcherDispatchMessagesInSubscriptionThread` to false.
BewareMyPower
requested review from
Technoboy-,
codelipenghui,
eolivelli,
lhotari,
mattisonchao and
merlimat
BewareMyPower
added
type/bug
mattisonchao
approved these changes
Jul 27, 2022
Technoboy-
approved these changes
Jul 27, 2022
Member
|
Hi, @BewareMyPower |
BewareMyPower
removed
the
release/blocker
Demogorgon314
approved these changes
Jul 27, 2022
Member
|
@eolivelli PTLA |
liudezhi2098
approved these changes
Jul 27, 2022
eolivelli
approved these changes
Jul 27, 2022
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
LGTM
I will take care of following up
Contributor
Author
|
Close it due to #16812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #16802 and the discussion in
#16803. Before reverting #16603,
disabling the
dispatcherDispatchMessagesInSubscriptionThreadoptionfirst.
Modifications
Change the default value of
dispatcherDispatchMessagesInSubscriptionThreadto false.Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)